ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

[UI] Dark theme currently not supported

Open gino-m opened this issue 5 years ago • 8 comments

Colors that don't look quite right

  • [ ] Toolbar background and nav icon
  • [ ] Surface container color, e.g., survey list backround

gino-m avatar Nov 09 '20 16:11 gino-m

@sufyanAbbasi Can we force light mode on for now, perhaps like this?

gino-m avatar Mar 13 '24 13:03 gino-m

Unfortunately, the solution <item name="android:forceDarkAllowed">false</item> only works on Android >=29, but we are currently targeting 24, most likely for backwards compatibility reasons.

It is possible to make a v29/styles.xml which will presumably apply to those versions or higher, but it looks like the style rules can end up skewing if we're not careful.

sufyanAbbasi avatar Mar 13 '24 18:03 sufyanAbbasi

Unfortunately, the solution <item name="android:forceDarkAllowed">false</item> only works on Android >=29, but we are currently targeting 24, most likely for backwards compatibility reasons.

It is possible to make a v29/styles.xml which will presumably apply to those versions or higher, but it looks like the style rules can end up skewing if we're not careful.

Can setDefaultNightMode() be used here

gino-m avatar Mar 13 '24 18:03 gino-m

I'll give it a shot!

sufyanAbbasi avatar Mar 13 '24 19:03 sufyanAbbasi

It actually worked!

sufyanAbbasi avatar Mar 13 '24 19:03 sufyanAbbasi