ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

Migrate to Kotlin

Open gino-m opened this issue 5 years ago • 5 comments
trafficstars

gino-m avatar Jul 07 '20 14:07 gino-m

Is there a recommendation for how to approach this? Should we start migrating classes which already have unit tests or should it be used for new classes only?

shobhitagarwal1612 avatar Apr 11 '22 04:04 shobhitagarwal1612

Is there a recommendation for how to approach this? Should we start migrating classes which already have unit tests or should it be used for new classes only?

Hi Shobhit, we discussed starting with new classes, tests, and necessary dependencies, and once we’re comfortable, migrating existing classes and tests as we go. Wdyt?

gino-m avatar Apr 11 '22 13:04 gino-m

Since I don't have any active PRs, I thought of migrating one or two of the existing classes to kotlin. But adhering to using Kotlin for new/modified code also sounds reasonable. Can't wait to get my hands dirty.

shobhitagarwal1612 avatar Apr 11 '22 14:04 shobhitagarwal1612

Since I don't have any active PRs, I thought of migrating one or two of the existing classes to kotlin. But adhering to using Kotlin for new/modified code also sounds reasonable. Can't wait to get my hands dirty.

I don't see why you couldn't grab some small ones while we're still in the 2.0 design phase. I don't have Kotlin "readability" yet, so maybe one of the other 20%ers could review? Please cc me so I can shadow and learn!

gino-m avatar Apr 11 '22 14:04 gino-m

just an FYI, I'm already altering all of the mutation objects, so just a heads up to avoid selecting those -- I'll have a PR for that out today

scolsen avatar Apr 11 '22 14:04 scolsen

Think it's safe to consider this one done?

scolsen avatar Dec 19 '22 21:12 scolsen

:+1:

shobhitagarwal1612 avatar Dec 20 '22 04:12 shobhitagarwal1612

Closing, while we're not 100% Kotlin just yet, much of the codebase has been migrated. We can continue to migrate classes over time if it makes sense.

scolsen avatar Dec 20 '22 16:12 scolsen