ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

Added version check through Remote Config

Open anandwana001 opened this issue 7 months ago • 4 comments

Fixes #2769

@shobhitagarwal1612 PTAL?

Screenshot 2025-05-29 at 3 43 19 PM

anandwana001 avatar May 29 '25 10:05 anandwana001

one test is failing when running - ./gradlew testLocalDebugUnitTest

signInProgressDialog_whenSignedOutAfterSignInState_isNotDisplayed

anandwana001 avatar Jun 04 '25 17:06 anandwana001

The UI for this dialog looks a bit different from the rest of the app. Can we make it consistent?

shobhitagarwal1612 avatar Jun 05 '25 12:06 shobhitagarwal1612

The UI for this dialog looks a bit different from the rest of the app. Can we make it consistent?

As discussed earlier in meeting, we will be doing the UI UX stuff as soon as we get the design. For this, the font, styles colors are matching

anandwana001 avatar Jun 05 '25 14:06 anandwana001

yes, it is only failing here, not sure why, looking into this

anandwana001 avatar Jun 05 '25 15:06 anandwana001

@anandwana001 I would add the min version number to a new doc, /config/app with {minAppVersion: '0.2.3'}. Only force the version update if the doc is present and if the app version is less than the major.minor.revision number.

gino-m avatar Jul 30 '25 10:07 gino-m

Codecov Report

:x: Patch coverage is 23.25581% with 33 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.50%. Comparing base (9e58c96) to head (428487d). :warning: Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...in/java/org/groundplatform/android/MainActivity.kt 9.09% 19 Missing and 1 partial :warning:
...n/java/org/groundplatform/android/MainViewModel.kt 18.75% 11 Missing and 2 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3150      +/-   ##
============================================
- Coverage     68.77%   68.50%   -0.27%     
- Complexity     1398     1402       +4     
============================================
  Files           290      290              
  Lines          7413     7456      +43     
  Branches        763      772       +9     
============================================
+ Hits           5098     5108      +10     
- Misses         1889     1919      +30     
- Partials        426      429       +3     
Files with missing lines Coverage Δ
...va/org/groundplatform/android/GroundApplication.kt 68.00% <100.00%> (+8.00%) :arrow_up:
...n/java/org/groundplatform/android/MainViewModel.kt 65.85% <18.75%> (-11.42%) :arrow_down:
...in/java/org/groundplatform/android/MainActivity.kt 45.66% <9.09%> (-7.67%) :arrow_down:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 07 '25 11:08 codecov[bot]