Offline areas are not deleted when signing out
@jo-spek @kenstershiro FYI for triage
@gino-m what is the impact of this, to help decide the severity? That the offline areas continue taking up space on the device? If they don't get deleted, are they re-used when you next sign in on that device (which could offset some of the downside)? Are there any other impacts to not deleting?
[@gino-m
](https://github.com/gino-m) what is the impact of this, to help decide the severity? That the offline areas continue taking up space on the device? If they don't get deleted, are they re-used when you next sign in on that device (which could offset some of the downside)? Are there any other impacts to not deleting?
Yep, that's right. I think it's a matter of correctness to remove data when signing out - I would be surprised if I signed out of an app and some of the data I added was still there when I signed back in. If the same device is used in multiple areas by different people, it would also be surprising and not be helpful to have that data stick around.
I suggest bumping this to P2. @kenstershiro Please revert back if you disagree.
@gino-m @kenstershiro Tested this, it is not happening on the latest master branch. Downloaded offline areas are getting deleted after sign out.
Did we check if the file is being deleted from local storage as well?
I don't recall ever seeing code to delete the image files when logging out. @anandwana001 Did you add this code?
@shobhitagarwal1612 raised #3231 to fix flakey tests for this PR