ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

[Survey list] Add section listing "public" surveys

Open gino-m opened this issue 10 months ago • 8 comments

A second query will need to be run to fetch surveys which are accessible to all users.

Depends on https://github.com/google/ground-platform/issues/2121.

@lecrabe FYI

gino-m avatar Feb 13 '25 15:02 gino-m

@vittorino Any ideas on how this would look in Android?

gino-m avatar Mar 27 '25 18:03 gino-m

@vittorino gentle nudge if you could prioritize this next, development on App has kicked off

kenstershiro avatar Apr 16 '25 14:04 kenstershiro

@gino-m here's a suggestion

Image

vittorino avatar May 16 '25 19:05 vittorino

This is great, thanks @vittorino ! Do you think surveys listed under "On this device" can be hidden from the other sections, or should they be shown there as well?

The green check already indicates "Available offline".. do we also need the chip?

gino-m avatar May 16 '25 19:05 gino-m

@anandwana001 FYI in case you want to start adding the section headings.

gino-m avatar May 16 '25 20:05 gino-m

Dependent on finalizing some UI questions. @anandwana001 will share what it looks like so far.

kenstershiro avatar May 30 '25 14:05 kenstershiro

Happy to make the call here.

  1. The "offline available" icon that's currently there can stay, we don't need the chip or progress indicate for now.
  2. Offline surveys shouldn't be shown again in other sections, only in the "On this device" section.

@anandwana001 Can you implement this?

gino-m avatar Jun 09 '25 12:06 gino-m

Happy to make the call here.

  1. The "offline available" icon that's currently there can stay, we don't need the chip or progress indicate for now.
  2. Offline surveys shouldn't be shown again in other sections, only in the "On this device" section.

@anandwana001 Can you implement this?

Already done in the PR https://github.com/google/ground-android/pull/3141 let me send for review once the testing done

anandwana001 avatar Jun 09 '25 12:06 anandwana001

UI part complete, PR is approved, one difficult test is failing. @anandwana001 will try to fix ASAP.

gino-m avatar Jul 25 '25 14:07 gino-m

@shobhitagarwal1612 Pointed out that the menu is removed in the design and PR, which I don't think is intentional. This PR only deals with listing headings. We still the overflow menu with "Remove offline.."

gino-m avatar Jul 25 '25 14:07 gino-m