ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

Display error toast or dialog when sign in fails

Open shobhitagarwal1612 opened this issue 1 year ago • 4 comments

Current behavior: Sign in request silent fails without any visible changes.

Expected behavior: Show show some error toast or dialog message.

Note: We only show a dialog if the sign in request fails due to permission denied error.

shobhitagarwal1612 avatar Nov 16 '24 07:11 shobhitagarwal1612

I think a simple toast with "Sign in failed" is sufficient. Removing @rawbzz

gino-m avatar Dec 06 '24 19:12 gino-m

@shobhitagarwal1612 the uncovered case at the moment (sign in failing when it's not to do with permission denied) would be some sort of technical error like a timeout for example right? For setting the priority correctly I just wanted to be sure the most common case of incorrect credentials is already giving toast dialog.

kenstershiro avatar Dec 13 '24 14:12 kenstershiro

@anandwana001 Can you verify whether this is still happening?

gino-m avatar Mar 14 '25 15:03 gino-m

@shobhitagarwal1612 Can you verify whether this still occurs?

gino-m avatar Mar 26 '25 15:03 gino-m