ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

If no surveys to fill out, back arrow in survey list is a no-op

Open jcqli opened this issue 1 year ago • 10 comments

After logging in to the app, if there are no surveys for you to collect data for then the back arrow does not do anything

Image

jcqli avatar Aug 23 '24 19:08 jcqli

@jcqli A Bit more detail

  1. For the very first time, the back arrow clicked, it recreates the fragment
  2. arrow click doesn't work

What should be the expected behavior?

https://github.com/user-attachments/assets/993612c1-e4be-4c00-a3e0-4a31aaae27d3

anandwana001 avatar Aug 28 '24 07:08 anandwana001

What should be the expected behavior?

It should exit the app

shobhitagarwal1612 avatar Aug 28 '24 11:08 shobhitagarwal1612

Hm exiting the app seems like an antipattern, are there other apps that do this? The current behavior for when there are surveys in the list is to sign to user out so maybe we should match that @gino-m wdyt?

jcqli avatar Aug 28 '24 13:08 jcqli

+1 @jcqli. The current design is obsolete, perhaps at this point it's just better to update the UI as per the new designs?

@rawbzz Can you paste in the latest here?

gino-m avatar Aug 28 '24 13:08 gino-m

New design includes the hamburger icon. Users can sign out from there if they have no surveys.

image

@kenstershiro @rawbzz FYI

gino-m avatar Aug 29 '24 14:08 gino-m

New design includes the hamburger icon. Users can sign out from there if they have no surveys.

@gino-m So, user can able to open the drawer and able to explore the whole app, right? Or do we need to show only signout in the drawer?

anandwana001 avatar Sep 09 '24 02:09 anandwana001

New design includes the hamburger icon. Users can sign out from there if they have no surveys.

@gino-m So, user can able to open the drawer and able to explore the whole app, right? Or do we need to show only signout in the drawer?

Yes, except the "Data sync status" option will be disabled:

image

gino-m avatar Sep 09 '24 14:09 gino-m

@shobhitagarwal1612 for this issue, we need to move our drawer layout from fragment to activity, as it is a good practice to let every fragment access the drawer.

Could you please confirm this approach, as this is bit sounds like a migration? All the drawer responsibilities should be handled by main activity and its ViewModel and HomeScreenFragment and it's Viewmodel will only see the maps and all

anandwana001 avatar Sep 11 '24 07:09 anandwana001

Let's prototype it once to understand the potential challenges we might face while doing this migration.

shobhitagarwal1612 avatar Sep 11 '24 09:09 shobhitagarwal1612

As per the last discussion with @shobhitagarwal1612 the plan from here is to sub-divide this issue:

  1. Jetpack Compose Migration #2803
  2. Once the Migration completes, Introduce Navigation Drawer in the MainActivity and remove from HomeFragment

anandwana001 avatar Oct 23 '24 05:10 anandwana001

@anandwana001 We spoke. The Jetpack migration sounds like it might take some time. In the meantime, can we just hide the button when there's nothing in the back stack; ie when clicking would be a no-op.

gino-m avatar Nov 04 '24 13:11 gino-m