ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

[Survey list] User unable to sign out if no surveys are accessible

Open gino-m opened this issue 1 year ago • 12 comments

After first sign in the "<-" button has no effect. The proposed solution is:

  • [ ] Replace the back/up button with the hamburger menu
  • [ ] Handle "no survey" state after first signing in
    • [ ] Show "Choose survey" and heading text shown below
    • [ ] Disable "Data sync status" menu option

Image

gino-m avatar Aug 16 '24 20:08 gino-m

Or should we just implement the new design? In that case, what does the hamburger icon do right after sign-in?

** obsolete image deleted **

gino-m avatar Aug 16 '24 20:08 gino-m

Shouldn't the hamburger menu open up the side panel?

rawbzz avatar Aug 19 '24 19:08 rawbzz

Shouldn't the hamburger menu open up the side panel?

That would make sense, a few follow-up questions:

  • In that case the user avatar would be shown both in the survey list and side panel. Should we remove it from the survey list then?
  • What do we show in the side panel when no survey has been selected yet?

gino-m avatar Aug 19 '24 20:08 gino-m

I feel like it'd be okay to remove from the survey list, esp if the main place a profile will live is in the side panel?

and also for no survey selected, I think we can do 2 things. One either prompt a user to choose a survey or hide that section completely?

Screenshot 2024-08-19 at 4 13 15 PM

rawbzz avatar Aug 19 '24 20:08 rawbzz

I think the last option makes sense, as it makes it clear that no survey is selected. Offline map imagery isn't per-survey, so it can stay active, but "Data sync status" (ex "History and sync status") should be disabled

gino-m avatar Aug 20 '24 20:08 gino-m

ok! disabled the data sync status

Screenshot 2024-08-21 at 12 48 37 PM

rawbzz avatar Aug 21 '24 16:08 rawbzz

LGTM!

gino-m avatar Aug 21 '24 16:08 gino-m

@amegantz for UXW - "you current have no survey.." sounds redundant.

gino-m avatar Aug 22 '24 14:08 gino-m

How about this? image No survey selected yet [Select a survey]

amegantz avatar Aug 27 '24 22:08 amegantz

@amegantz Do we need the work "yet"? If feels a little extra, no?

gino-m avatar Aug 28 '24 01:08 gino-m

YOU feel a little extra.

Just kidding, we can do without the "yet." It's a casual tone thing I added since we had the space

amegantz avatar Aug 29 '24 20:08 amegantz

Haha, ok, sgtm!

gino-m avatar Aug 29 '24 20:08 gino-m

There's already a fixed issue to disable the up button #2692, so recasting this as a feature request.

gino-m avatar Nov 13 '24 13:11 gino-m