ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

[Code health] DrawArea* tests are fragile - consider revising

Open gino-m opened this issue 1 year ago • 0 comments

DrawAreaTaskViewModel and DrawAreaTaskFragmentTest contain helper functions with non-trivial branching logic (TotT 07-2014, and occasionally test via internal methods rather than testing public behaviors (ToTT 08-2013). Consider simplifying tests accordingly. Each test method also tests multiple behaviors, leading to later failing checks being masked by checks run earlier. Instead, we should test one behavior per test method.

@shobhitagarwal1612 FYI.

gino-m avatar Jan 02 '24 19:01 gino-m