ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

[PhotoSync] Track upload/retry status of individual photos

Open scolsen opened this issue 2 years ago • 5 comments

Right now, we batch process and batch retry photo uploads. This means we attempt to re-upload photos when one upload in the batch fails even if the other photos in question were successfully uploaded. Tracking upload status on a per-photo basis instead will allow us to avoid this duplicative work.

scolsen avatar Dec 14 '23 21:12 scolsen

@rawbzz -- could use some UX help in figuring out the best way to indicate the status of individual photo uploads when you get a chance! Each photo upload can succeed/fail individually, and each submission may have one or more photo associated with it. lmk if I can provide more context, thanks!

scolsen avatar Feb 14 '24 20:02 scolsen

@scolsen Yes! Do you have any screenshots of what currently happens right now?

rawbzz avatar Feb 14 '24 21:02 rawbzz

@scolsen Yes! Do you have any screenshots of what currently happens right now?

@rawbzz This is lower priority, so removing milestone and bumping to P2. There are a few high priority questions tagged for you there when you a sec!

For posterity, this is the redesigned status screen which we're targeting for next week (minus the user names):

image

gino-m avatar Feb 15 '24 21:02 gino-m

This code:

https://github.com/google/ground-android/blob/17422bdd7f9b3cd1b8bdec94f0a6f1f4a10a5245/ground/src/main/java/com/google/android/ground/persistence/sync/MediaUploadWorker.kt#L117-L122

Is incorrect in that the calling function decided the retry behavior based on only one of the photo upload results. Reclassifying as bug.

gino-m avatar Nov 20 '24 18:11 gino-m

@scolsen Adding as low priority for Iteration 27.

gino-m avatar Dec 03 '24 21:12 gino-m