ground-android icon indicating copy to clipboard operation
ground-android copied to clipboard

[Code health] Rename `ground` folder back to `app`

Open gino-m opened this issue 2 years ago • 18 comments
trafficstars

The path ground-android/ground is slightly confusing, and seems to imply the level about it is not actually part of ground.

Perhaps the default app would be more appropriate here?

@scolsen @JSunde @shobhitagarwal1612 for thoughts.

gino-m avatar Jan 03 '23 21:01 gino-m

app sgtm

scolsen avatar Jan 03 '23 21:01 scolsen

@JSunde @shobhitagarwal1612 Are you ok with this change as well?

gino-m avatar Jan 03 '23 22:01 gino-m

Yes. This seems ok to me as well

shobhitagarwal1612 avatar Jan 04 '23 03:01 shobhitagarwal1612

SIr may I help you in this ?

Sachin-2206 avatar Jan 04 '23 11:01 Sachin-2206

Hi @Sachin-2206, thanks for offering to help!

Can you kindly sign https://cla.developers.google.com/clas before proceeding?

gino-m avatar Jan 04 '23 15:01 gino-m

@gino-m I would love to handle this issue if it's free

EmmanuelDav avatar Jan 04 '23 22:01 EmmanuelDav

@gino-m Sir I want to know that I just rename the 'ground' folder name to 'app' ?

Sachin-2206 avatar Jan 06 '23 16:01 Sachin-2206

@gino-m I just need a little help to know that what I exactly have to do in this issue. May you help me please ?

Sachin-2206 avatar Jan 06 '23 16:01 Sachin-2206

Done

EmmanuelDav avatar Jan 08 '23 23:01 EmmanuelDav

@gino-m Sir I want to know that I just rename the 'ground' folder name to 'app' ?

@Sachin-2206, yes, that's correct. The path to the module will also need to be updated in relevant config files (*.gradle, *.yaml).

@EmmanuelDav This issue was already assigned. Please wait for issues to be assigned to you before proceeding. Thanks!

gino-m avatar Jan 09 '23 01:01 gino-m

Ok. My apologies

EmmanuelDav avatar Jan 09 '23 21:01 EmmanuelDav

@gino-m Sir I rename ground folder name to app folder name. and I also rename the package name of all files of ground folder to app. Is it correct or should I change something else. I will send the sample or screenshot , check it and tell me as soon as possible. Screenshot (1)

Sachin-2206 avatar Jan 10 '23 11:01 Sachin-2206

@gino-m Sir I rename ground folder name to app folder name. and I also rename the package name of all files of ground folder to app. Is it correct or should I change something else. I will send the sample or screenshot , check it and tell me as soon as possible. Screenshot (1)

The package name does not need to change, only the module folder name at project root level. Thanks!

gino-m avatar Jan 10 '23 12:01 gino-m

Hello @Sachin-2206 , Are you still working on this issue? If not, I would love to take this up. Thankyou.

devedroy avatar Apr 27 '23 11:04 devedroy

@devedroy Sorry for late reply, still interested in taking this one?

gino-m avatar Dec 19 '23 21:12 gino-m

@gino-m Thanks for the reply. Yes, I would love to take up this issue.

devedroy avatar Dec 20 '23 05:12 devedroy

@gino-m Thanks for the reply. Yes, I would love to take up this issue.

Please go ahead!

gino-m avatar Dec 20 '23 15:12 gino-m

@devedroy Let me know if you're still interested and we can reassign.

gino-m avatar Apr 17 '24 21:04 gino-m