Convert MultipleChoice to Kotlin

[JSunde]

trafficstars

[codecov-commenter]

Codecov Report

Merging #1202 (511f02a) into master (47b7b11) will decrease coverage by 0.17%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1202      +/-   ##
============================================
- Coverage     29.73%   29.56%   -0.18%     
+ Complexity      785      782       -3     
============================================
  Files           291      292       +1     
  Lines          7630     7603      -27     
  Branches        348      347       -1     
============================================
- Hits           2269     2248      -21     
+ Misses         5253     5246       -7     
- Partials        108      109       +1     

Impacted Files	Coverage Δ
...del/locationofinterest/LocationOfInterestType.java	0.00% <0.00%> (-100.00%)	:arrow_down:
...ogle/android/ground/repository/SurveyRepository.kt	76.56% <0.00%> (-8.52%)	:arrow_down:
.../ground/system/auth/GoogleAuthenticationManager.kt	0.00% <0.00%> (ø)
...round/persistence/local/room/entity/JobEntity.java	100.00% <0.00%> (ø)
...ound/persistence/local/room/entity/TaskEntity.java	82.35% <0.00%> (ø)
...und/persistence/local/room/RoomLocalDataStore.java	72.10% <0.00%> (ø)
...nd/persistence/local/room/entity/OptionEntity.java	0.00% <0.00%> (ø)
...ersistence/remote/firestore/schema/JobConverter.kt	0.00% <0.00%> (ø)
...rsistence/remote/firestore/schema/TaskConverter.kt	0.00% <0.00%> (ø)
...istence/remote/firestore/schema/OptionConverter.kt	0.00% <0.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[JSunde]

LGTM! Please just fix build errors.

e: /workspace/ground/src/main/java/com/google/android/ground/persistence/local/room/converter/ResponseJsonConverter.kt: (82, 53): Type mismatch: inferred type is MultipleChoice? but MultipleChoice was expected
e: /workspace/ground/src/main/java/com/google/android/ground/persistence/local/room/converter/ResponseJsonConverter.kt: (85, 53): Type mismatch: inferred type is MultipleChoice? but MultipleChoice was expected
e: /workspace/ground/src/main/java/com/google/android/ground/persistence/remote/firestore/schema/SubmissionConverter.kt: (125, 41): Type mismatch: inferred type is MultipleChoice? but MultipleChoice was expected

Oh actually I'm realizing there were legitimate non-test use cases where the MultipleChoice field of MultipleChoiceResponse was null. I'm guessing we want to mark it as nullable then?

WDYT?

[gino-m]

It probably shouldn't be the case, but if that's the current state let's do that and fix the root cause in a follow-up.