googletest icon indicating copy to clipboard operation
googletest copied to clipboard

[Bug]: CMake Quickstart: policy CMP0135 is not set.

Open Nickrader opened this issue 1 year ago • 3 comments

Describe the issue

CMake Quickstart: When building per instructions, after exectuting: cmake -S . -B build

"CMake Warning (dev) at /usr/share/cmake-3.24/Modules/FetchContent.cmake:1267 (message): The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is not set. "

Steps to reproduce the problem

https://github.com/Nickrader/GTestCMakeQuickstart

What version of GoogleTest are you using?

Latest to fix error.

What operating system and version are you using?

Lubuntu 22.10

What compiler and version are you using?

gcc version 12.2.0 (Ubuntu 12.2.0-3ubuntu1)

What build system are you using?

cmake version 3.24.2

Additional context

Unsure about implementation of fix. Simple enough to use latest commit and GIT_REPOSITORY, GIT_TAG.

To use URL it seems setting CMP0135 to NEW would be solution, based on other similar problems/solutions. Unsure where to set, as error didn't point to source code in Googletest.

Nickrader avatar Jun 19 '23 20:06 Nickrader

Steps to Reproduce

Using the given repo can't reproduce the problem.

cosmic@zack ~/c/c/p/GTestCMakeQuickstart (stable)> cmake -S . -B build
-- The C compiler identification is GNU 13.1.1
-- The CXX compiler identification is GNU 13.1.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Python: /usr/bin/python3.11 (found version "3.11.3") found components: Interpreter 
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Configuring done (43.4s)
-- Generating done (0.0s)
-- Build files have been written to: /home/cosmic/coding/cpp/playground/GTestCMakeQuickstart/build
  • cmake version: 3.26.4
  • gcc version: 13.1.1
  • OS: Arch Linux

CosmicPegasis avatar Jul 18 '23 06:07 CosmicPegasis

I probably shouldn't have the repository head point to my workaround.
Updated repo to point to error, made separate branch for workaround.

Nickrader avatar Jul 18 '23 22:07 Nickrader