googletest icon indicating copy to clipboard operation
googletest copied to clipboard

Move NOLINT comment to first line of assignment operator declaration

Open HighCommander4 opened this issue 2 years ago • 1 comments

Fixes https://github.com/google/googletest/issues/4110

HighCommander4 avatar Jan 02 '23 09:01 HighCommander4

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 02 '23 09:01 google-cla[bot]

Hey! looks like we still need you to sign the CLA. Please let me know when that's been done.

asoffer avatar Jan 30 '23 17:01 asoffer

Based on https://github.com/google/googletest/issues/4110#issuecomment-1376290123, it sounds like this patch wouldn't be accepted anyways, so I should probably close this.

HighCommander4 avatar Jan 30 '23 18:01 HighCommander4