googletest icon indicating copy to clipboard operation
googletest copied to clipboard

Add support for streaming results on Windows (fixes #3935).

Open davidmatson opened this issue 3 years ago • 7 comments

davidmatson avatar Aug 29 '22 19:08 davidmatson

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 29 '22 19:08 google-cla[bot]

@asoffer - would you mind approving the workflow so it can run? Thanks!

davidmatson avatar Sep 20 '22 22:09 davidmatson

@asoffer - I fixed the workflow errors locally; if you wouldn't mind re-approving to run again, that would be great - thanks!

davidmatson avatar Sep 27 '22 01:09 davidmatson

@asoffer - re-configured to include gmock tests and fixed those too; if you wouldn't mind re-approving to run again, that would be great - thanks!

davidmatson avatar Sep 29 '22 20:09 davidmatson

@asoffer - I'm not sure what's happening with the failing tests. The only one that failed before locally seemed completely unrelated to code that's changing in this PR. I rebased on the latest in upstream main and added a commit that fixes that PR locally, but I'm not sure why that would be needed unless that test is already failing upstream.

There's also one failing in the workflow that isn't failing locally:

//googletest/test:gtest_unittest                                         FAILED in 1 out of 2 in 0.3s
...
 C:/users/runneradmin/_bazel_runneradmin/olwzt263/execroot/com_google_googletest/bazel-out/x64_windows-fastbuild/testlogs/googletest/test/gtest_unittest/shard_2_of_2/test.log

Any idea what's happening here?

davidmatson avatar Oct 03 '22 22:10 davidmatson

@asoffer - any thoughts on this PR - thanks!

davidmatson avatar Nov 28 '22 18:11 davidmatson

@asoffer - could you review this PR? Thanks!

davidmatson avatar Jan 12 '23 18:01 davidmatson