googletest icon indicating copy to clipboard operation
googletest copied to clipboard

Add version check for QNX systems before linking regex

Open samkearney opened this issue 2 years ago • 4 comments

This is a follow up for #3713. For QNX RTOS, regex functionality was broken out into a separate library libregex as of version 7.1. However, in earlier versions, the same functionality is present in the core libc, and libregex doesn't exist. This causes problems when trying to configure GoogleTest using a toolchain for QNX < 7.1.0.

You can see the difference by comparing point 2 in the reference page for two different versions:

Version 7.0: http://www.qnx.com/developers/docs/7.0.0/#com.qnx.doc.ide.userguide/topic/writing_test_programs.html

Version 7.1: https://www.qnx.com/developers/docs/7.1/#com.qnx.doc.ide.userguide/topic/writing_test_programs.html

This PR allows GoogleTest to build successfully on QNX toolchains < 7.1.0.

cc @PhilipMourdjis the author of the previous PR that added this line.

samkearney avatar Jun 16 '22 13:06 samkearney

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 16 '22 13:06 google-cla[bot]

@derekmauro anything I can do to help get this merged? Thanks!

samkearney avatar Sep 29 '22 20:09 samkearney

Just a friendly ping for this PR on its one-year anniversary. Thanks! 😄

samkearney avatar Jun 16 '23 13:06 samkearney

It looks fine to me @derekmauro

PhilipMourdjis avatar Jun 16 '23 17:06 PhilipMourdjis

Closing, as a later identical PR #4444 was accepted.

samkearney avatar Jun 11 '24 19:06 samkearney