googletest
googletest copied to clipboard
Use `-lm` on linux as well.
Not all compilers on linux add it implicitly. It won't do any harm on those which do.
Closes #3878
Hi,
There has been progress with this PR :) ?
I confirm that clang requires -lm
This is just waiting for someone with permission to actually review and (hopefully) merge it (the test failures shown in the checks output were present on master as well at the time they ran). Our team has been using this branch for a long time now.
Hi,
I think that Bazel 6 allows to do a selection depending on the compiler (gcc or clang), see @bazel_tools//tools/cpp:compiler
Maybe -lm
can be added only for clang, but I think that this would require Bazel 6.
Yes I think that would require bazel 6. And even after it's been released, it'll be a while before bazel 6 can be assumed.