googletest icon indicating copy to clipboard operation
googletest copied to clipboard

Add User Exception Handler

Open Andrysky opened this issue 3 years ago • 8 comments

https://github.com/google/googletest/issues/3433

Andrysky avatar Aug 05 '21 20:08 Andrysky

I commented on #3433 that we would not accept a patch that adds a custom exception handler, and it appears that is what this CL does.

derekmauro avatar Aug 09 '21 19:08 derekmauro

I commented on #3433 that we would not accept a patch that adds a custom exception handler, and it appears that is what this CL does.

aa .. ( and why? if you need i add definitions so that this code is when adding some compile flag. and since custom exceptions can be anything - installing a handler is the only one option that I can see so far (

Andrysky avatar Aug 10 '21 04:08 Andrysky

David Merwin has invited you to work on "Matrix 1" using Priority Matrix for Office 365. Together, you can manage projects, conduct one-on-one meetings, and easily turn emails into tasks.

https://sync.appfluence.com/download_flow?invited_o365&msft_only

	For your convenience, this is your sign in information:

username: @.*** password: ZippingPager57 (reset it as soon as possible)

Priority Matrix is a Microsoft 365 Security Certified solution (the first project management software to earn that status) that helps you manage priorities, emails, meetings, and critical projects, both inside and outside Microsoft Teams and Outlook. To get started, install Priority Matrix on your computer, and also on Microsoft Teams and Outlook.

https://sync.appfluence.com/pm_fwd/?fwd=https://appfluence.com/office-365-project-management-integration/?registered_welcome

Over the next few days you will receive a series of messages to show you the system. You can open your email preferences (https://sync.appfluence.com/accounts/unsubscribe/605115/d38bdd57cd243138e1e965280358647b/?) and uncheck the "news" box to stop that.

To learn more, watch a short video introduction (https://www.youtube.com/watch?v=J_lbIuEJgpw&list=PLNBKhU8HtrpTdV8bx6ExlVWTg0sae0KFe) explaining how Priority Matrix for Microsoft Teams and Outlook (Microsoft Editor's Choice app!) can help you better manage priorities, emails, and meetings.

Sincerely, The Priority Matrix team

davidmerwin avatar Aug 13 '21 16:08 davidmerwin

--- Reply above this line (Ref. 2047395347/8ef9ef7dd0b445ec58c23eb6e23167f56c2ed825e5dc79c4bb49b55edca425c6)

David uploaded a .pdf file to 'Matrix 1', in project 'Johns Hopkins,' quadrant 'Do Now.'

Hit reply-all to continue this conversation. Learn more about this feature on our website: https://appfluence.com/help/article/commands-priority-matrix/?ref=follow

If you don't want to receive messages like this one, open your email preferences (https://sync.appfluence.com/accounts/unsubscribe/605115/d38bdd57cd243138e1e965280358647b/?), to disable "Instant emails", then save.

Manage notifications or unsubscribe: https://sync.appfluence.com/accounts/unsubscribe/605115/d38bdd57cd243138e1e965280358647b/?

davidmerwin avatar Aug 13 '21 16:08 davidmerwin

--- Reply above this line (Ref. 2047395347/8ef9ef7dd0b445ec58c23eb6e23167f56c2ed825e5dc79c4bb49b55edca425c6)

David uploaded an image to 'Matrix 1', in project 'Johns Hopkins,' quadrant 'Do Now.'

Hit reply-all to continue this conversation. Learn more about this feature on our website: https://appfluence.com/help/article/commands-priority-matrix/?ref=follow

If you don't want to receive messages like this one, open your email preferences (https://sync.appfluence.com/accounts/unsubscribe/605115/d38bdd57cd243138e1e965280358647b/?), to disable "Instant emails", then save.

Manage notifications or unsubscribe: https://sync.appfluence.com/accounts/unsubscribe/605115/d38bdd57cd243138e1e965280358647b/?

davidmerwin avatar Aug 13 '21 16:08 davidmerwin

@derekmauro 👀

Andrysky avatar Aug 15 '21 05:08 Andrysky

@derekmauro Can you explain why a custom handler won't be accepted? What would be accepted? I can dream up other ways than @Andrysky has implemented here, but they all ultimately require registering one or more functions/methods/lambdas with googletest to extract the additional information from the custom exception.

beavis9k avatar Oct 28 '21 02:10 beavis9k

We have the same need; our application uses two custom exception types (not derived from std::exception etc) and we need to be able to catch them whenever they are unexpectedly thrown from code under test and report their messages. This custom exception handler approach seems like a good, low-coupling way to extend gtest for these needs. I would request that you accept this patch.

peakschris avatar Sep 27 '22 18:09 peakschris