IntelliJ Plugin with AOSP inserts incorrect blank lines during optimize imports

[Gellardo]

When using the IntelliJ google-java-formatter 1.16.0.2 with the AOSP style, the "Optimize Imports" action results in empty lines between imports with different TLDs.

Given:

// ...
import static org.assertj.core.api.Assertions.assertThat;
import lombok.extern.slf4j.Slf4j;
import org.junit.jupiter.params.ParameterizedTest;
import java.io.ByteArrayOutputStream;
import java.io.FileInputStream;
// ...

Results in:

// ...
import static org.assertj.core.api.Assertions.assertThat;

import lombok.extern.slf4j.Slf4j;

import org.junit.jupiter.params.ParameterizedTest;

import java.io.ByteArrayOutputStream;
import java.io.FileInputStream;
// ...

Expected:

When using spotless:check with google-java-formatter 0.16.0 / 0.17.0 and AOSP, it complains that all but the first empty line have to be removed. The online documentation seems to agree with spotless.

The IntelliJ plugin does not break the Google Java Style Guide when executing "optimize imports".

Context

This being inconsistent between spotless and Intellij is very inconvenient. We use use spotless in the CI to enforce the codestyle and this necessitates running mvn spotless:apply for every commit or disabling "optimize imports" which itself results in manual cleanup of unused imports.

I have tried it with the default GOOGLE style and that does not seem to have this problem.

[realdadfish]

This is happening for me as well when the "AOSP" style is selected, but not during "Optimize Imports", but with the basic "Reformat Code" action. This is really a downer, since the Gradle task verifyGoogleJavaFormat then disagrees and does not want to see blank lines, whereas the IJ plugin automatically creates new blank lines with the next reformat.

It also made no differences to clear out the import layout in IJ's code style settings (as expected), the blank lines are added by the plugin anyways.

I'm using GJF 1.19.1 and the IJ plugin 1.17.0.0. It also makes no difference if the Gradle plugin's GJF version is downgraded to 1.17.0, same results.

[199911]

I got the same issue with AOSP style is selected

• IntelliJ IDEA 2023.3.3 (Ultimate Edition)
• google-java-format (1.16.0.2 and 1.19.2.0)

[erik-sab]

Same here:

• IntelliJ IDEA 2024.1 (Ultimate Edition)
• google-java-format (1.21.0.0)

it makes it impossible to use maven plugin in combination with intellij.

There is an issue to respect Intellij imports settings https://github.com/google/google-java-format/issues/986 as it was in older version of plugin.