google-java-format icon indicating copy to clipboard operation
google-java-format copied to clipboard

Please document the role of Active profile in Eclipse configuration

Open oliviercailloux opened this issue 3 years ago • 5 comments

The README states: “The plugin adds a google-java-format formatter implementation that can be configured in Window > Preferences > Java > Code Style > Formatter > Formatter Implementation.”

It is unclear what can be configured exactly, or whether anything can be configured, considering the note in the same file: “There is no configurability as to the formatter's algorithm for formatting. This is a deliberate design decision to unify our code formatting on a single format.”

Relatedly, the role of the Active profile dialog box is not clear.

I just tested changing the number of spaces in the active profile, and this seems to have no effect on Source / Format when the google-java-format implementation is selected.

Please add some explanations about what can be configured and which Active profile should be chosen or indicate if it is supposed to have no effect.

oliviercailloux avatar Aug 23 '21 08:08 oliviercailloux

Possibly related to #260.

oliviercailloux avatar Aug 23 '21 08:08 oliviercailloux

Also seeing the same thing. If the google-java-format formatter is selected (with 1.13.0 and the latest version of Eclipse), when I try to format code, absolutely nothing happens. If I go back to the Eclipse built-in formatter, it does format the code. I'm not sure if I'm missing a step or if the plugin is currently broken?

seeruk avatar Jan 11 '22 15:01 seeruk

Still happening with the 1.15 release.

greg-dennis avatar Mar 14 '22 04:03 greg-dennis