google-java-format
google-java-format copied to clipboard
This adds an AOSP formatter to the Eclipse plugin.
This is achieved by creating two different Eclipse Java Formatter implementations
that are selectable in the Java Code Style > Formatter preferences.
The google-java-format
acts just the same. A new aosp-java-format
enables AOSP options.
Internally this is achieved by giving the SnippetFormatter the ability
to accept JavaFormatterOptions
.
This addresses: https://github.com/google/google-java-format/issues/179
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
go go googlebot
CLAs look good, thanks!
Thanks for the quick feedback! @Stephan202
Hi, we just switched our open source project(s) to Google AOSP and a release with this PR merged would be awesome :-)
Any help needed to make this merged?
The branch currently has conflicts.
- @bryanschofield do you think you can resolve them?
- Any feedback from the Google team on whether this change is viable would be appreciated.
(GJF is a tremendous time saver; it'd be great to see this tool adopted as widely as possible. Changes such as these definitely help achieve that.)
Any update on this?