go-metrics-stackdriver icon indicating copy to clipboard operation
go-metrics-stackdriver copied to clipboard

NewSink constructor should accept an interface

Open tam7t opened this issue 3 years ago • 0 comments

https://pkg.go.dev/github.com/google/go-metrics-stackdriver#NewSink

currently only accepts a https://pkg.go.dev/cloud.google.com/go/monitoring/apiv3#MetricClient

which says:

Deprecated: Please use cloud.google.com/go/monitoring/apiv3/v2.

This was also mentioned https://github.com/google/go-metrics-stackdriver/pull/16 but would be a breaking change to the package.

tam7t avatar Sep 01 '21 19:09 tam7t