go-github icon indicating copy to clipboard operation
go-github copied to clipboard

Published 20 hours ago • verified publisher icon google

Include example for custom/caching transport and oauth usage

Open tmc opened this issue 6 years ago • 13 comments

Providing a custom Transport with oauth2 is a little verbose and having an example usage of it here would be useful:

ctx := context.WithValue(oauth2.NoContext, oauth2.HTTPClient, client)

tmc avatar Aug 31 '18 01:08 tmc

I would like to take it.

urohit011 avatar Sep 03 '18 16:09 urohit011

@gmlewis @tmc Is this issue still open for working?

shubhodeep9 avatar Dec 26 '18 08:12 shubhodeep9

@urohit011 - do you still want to work on this, or shall we assign it to @shubhodeep9 ?

@shubhodeep9 - let's give @urohit011 a couple days to answer and if we have still not heard back, we'll assign it to you.

gmlewis avatar Dec 26 '18 14:12 gmlewis

@gmlewis Happy New Year, would like to know the status if I can work on this?

shubhodeep9 avatar Jan 02 '19 10:01 shubhodeep9

Happy New Year to you too, @shubhodeep9! Sure, I think it is safe for you to take this issue.

I'm unable to send you an invite, but by this comment, please will see that you are assigned to this issue.

gmlewis avatar Jan 02 '19 12:01 gmlewis

@gmlewis Can you assign me the issue in case this issue is available.

IamRaviTejaG avatar Jan 13 '19 09:01 IamRaviTejaG

@shubhodeep9 - are you still working on this issue? If not, @ImRaviTejaG would like to take it.

@ImRaviTejaG - let's give @shubhodeep9 a couple days to respond before we switch it to you. Thanks.

gmlewis avatar Jan 13 '19 13:01 gmlewis

@gmlewis sorry, been caught up with something. Give me 3 days, if not done, then I will surely convey to assign it to someone else. Thank you

shubhodeep9 avatar Jan 13 '19 13:01 shubhodeep9

@gmlewis Sure! @shubhodeep9 Thanks for the quick revert. I await your PR. 😄

IamRaviTejaG avatar Jan 13 '19 15:01 IamRaviTejaG

@gmlewis apologies for blocking time, you may assign it to @ImRaviTejaG

Thanks

shubhodeep9 avatar Jan 16 '19 07:01 shubhodeep9

No problem, @shubhodeep9.

@ImRaviTejaG - this issue is now assigned to you.

gmlewis avatar Jan 16 '19 12:01 gmlewis

@gmlewis Thanks! Please give me a heads up on where to get started so that I can get it done quickly.

IamRaviTejaG avatar Jan 16 '19 14:01 IamRaviTejaG

Hi @ImRaviTejaG - I removed the "good first issue" tag, as maybe that is not appropriate for this issue.

Ideally, someone who has experience using oauth2 (and can provide a simple example) would take on this issue. If you don't feel that this is you, then feel free to decline and we will leave this open for someone else to provide.

Thanks for your understanding.

gmlewis avatar Jan 16 '19 14:01 gmlewis