go-github icon indicating copy to clipboard operation
go-github copied to clipboard

refactor!: Support array type for `CustomProperty.DefaultValue` field

Open zyfy29 opened this issue 3 months ago • 3 comments

BREAKING CHANGE: CustomProperty.DefaultValue was *string but now is any.

Fixes: #3692. Fixes: #3741.

zyfy29 avatar Sep 27 '25 03:09 zyfy29

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 91.11%. Comparing base (138500e) to head (6abfd62).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3740   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files         187      187           
  Lines       16697    16697           
=======================================
  Hits        15213    15213           
  Misses       1296     1296           
  Partials      188      188           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 27 '25 12:09 codecov[bot]

Oh, sorry, now it should be OK

zyfy29 avatar Sep 28 '25 01:09 zyfy29

I don't think I agree with the API design for this, I was planning on having this discussion on the issue when I had time to pick it up or someone else wanted to. This comment is to hold the PR while we discuss the implementation in #3692.

Ah, OK. Let's put this PR on hold then while it is being discussed.

gmlewis avatar Sep 29 '25 12:09 gmlewis