OrganizationsService.GetPackage escapes packagName, but UserService.GetPackage does not

[jhrozek]

It seems that the OrganizationsService does escape package names by calling url.PathEscape, but the UserService does not.

Is this a bug or is there a reason behind escaping one of the APIs but not the other?

If this is a simple bug, I'll be happy to submit a fix.

[gmlewis]

This looks like a bug to me. Sounds great... thank you, @jhrozek ! Please remember to add unit tests that demonstrate at least one package name that requires escaping.

[gmlewis]

Also, our CONTRIBUTING.md guide has useful information in it.

[DiegoDev2]

hi! @gmlewis I'm interested in the problem, apparently the boy didn't do anything about it.

[gmlewis]

OK, thank you, @DiegoDev2 - it's yours.

[DiegoDev2]

while I was testing some of the unit tests it gave me FAIL:

 go test -v orgs_packages_test.go
# command-line-arguments [command-line-arguments.test]
./orgs_packages_test.go:18:30: undefined: setup
./orgs_packages_test.go:22:3: undefined: testMethod
./orgs_packages_test.go:50:20: undefined: referenceTimeStr
./orgs_packages_test.go:51:20: undefined: referenceTimeStr
./orgs_packages_test.go:61:67: undefined: PackageListOptions
./orgs_packages_test.go:66:13: undefined: Package
./orgs_packages_test.go:67:17: undefined: Int64
./orgs_packages_test.go:68:17: undefined: String
./orgs_packages_test.go:69:17: undefined: String
./orgs_packages_test.go:70:17: undefined: Int64
./orgs_packages_test.go:70:17: too many errors
FAIL    command-line-arguments [build failed]
FAIL

go test -v users_packages_test.go
# command-line-arguments [command-line-arguments.test]
./users_packages_test.go:18:30: undefined: setup
./users_packages_test.go:22:3: undefined: testMethod
./users_packages_test.go:23:3: undefined: testFormValues
./users_packages_test.go:23:24: undefined: values
./users_packages_test.go:31:20: undefined: referenceTimeStr
./users_packages_test.go:32:20: undefined: referenceTimeStr
./users_packages_test.go:38:58: undefined: PackageListOptions
./users_packages_test.go:38:90: undefined: String
./users_packages_test.go:43:13: undefined: Package
./users_packages_test.go:44:17: undefined: Int64
./users_packages_test.go:44:17: too many errors
FAIL    command-line-arguments [build failed]
FAIL

does this not matter? Or should the test go well?

[gmlewis]

@DiegoDev2 - That is not how you run unit tests in Go.

Try this instead: go test -v ./...

Please read CONTRIBUTING.md for more information.

[Abiji-2020]

@gmlewis Can i look into this issue.

[gmlewis]

@gmlewis Can i look into this issue.

Sure, @Abiji-2020 - it's yours.