google
Changes from issue #1634 to remove preview header: antiope breaks support for Github Enterprise
Github and Github enterprise have different release cycles and time to release features for granduate feature from preview state.
The changes to remove the check api preview header (#1634) break compatibility for github enterprise.
Is there any chance to active the header again or make it configurable?
Is there any reason why you can't remain on the version of this repo that still provided this custom preview header?
Well, go-github is used by https://github.com/palantir/bulldozer. Older bulldozer versions does not work anymore with github enterprise. So I had to upgrade. Bulldozer developers decided to upgrade to go-github/v38. As result the tool became incompatible to github enterprise in another way because ghe has still check api in preview state.
May you could make it configurable so bulldozer could provide a configuration for github enterpise support.
Oh, OK, I see your dilemma. We can revert #1636 and re-address that issue some time in the distant future. I can work on that later today unless there are any objections.
Oh, OK, I see your dilemma. We can revert #1636 and re-address that issue some time in the distant future. I can work on that later today unless there are any objections.
Before I do that, however, can you please take a look at this thread: https://github.com/google/go-github/issues/1859#issuecomment-883588235
and see if the proposed Client() solution is sufficient to give you a workaround to call an older version of this client library (which has support for the custom preview header you are interested in)?
Thanks for the fast reply. I am to admit I am not involved in bulldozer project. And I am not familiar with Golang. I am just enduser from bulldozer who looks for a solution.
I compiled a custom version from latest bulldozer code + revert the removal from the header in go-github code. And the solution works well.
I opened a ticket for bulldozer to discuss solution options: https://github.com/palantir/bulldozer/issues/260. I hope bulldozer owners can help to sort out which solution is the best and if the proposed client aspect above may help.
Seems the bulldozer guys did not comment here. Finally I built my custom custom bulldozer version and will stick with till the github version get an update. Thanks for the help.