go-cmp icon indicating copy to clipboard operation
go-cmp copied to clipboard

Avoid disabling dead code elimination when using Equal

Open pgimalac opened this issue 1 year ago • 1 comments

Partially fixes https://github.com/google/go-cmp/issues/373 (Equal only).

This PR moves code around to allow the linker to statically determine that the code using reflect.Type.Method is not reachable from the Equal function. It replaces the type name logic of unnamed interfaces to just use reflect.Type.String() when the qualified argument of appendTypeName is false. The only difference in the output is that there is a space added between interface and the opening bracket.

pgimalac avatar Feb 18 '25 12:02 pgimalac

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Feb 18 '25 12:02 google-cla[bot]