gnostic icon indicating copy to clipboard operation
gnostic copied to clipboard

If fq_schema_naming is true, use service fullname as the operation tagname

Open comynli opened this issue 3 years ago • 3 comments

When fq_ schema_naming is set to true, use service full name as tag of operation. like schema use message full name as title.

comynli avatar Nov 15 '22 11:11 comynli

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Nov 15 '22 11:11 google-cla[bot]

Let's fix the broken tests before merging. I'll take a look later today, we may just need to update the expected results.

timburks avatar Mar 24 '23 18:03 timburks

You can also temporarily set this to true https://github.com/google/gnostic/blob/main/cmd/protoc-gen-openapi/plugin_test.go#L50 then run the tests. It will recreate the fixtures, which you can then diff to see if the changes make sense.

jeffsawatzky avatar Apr 12 '23 18:04 jeffsawatzky