gnostic icon indicating copy to clipboard operation
gnostic copied to clipboard

Generated proto file doesn't contain go_package option

Open egonz opened this issue 4 years ago • 4 comments

It appears in this PR https://github.com/googleapis/gnostic/pull/165/files go_package was added, but running gnostic doesn't include it, and protoc generates warnings because it is missing. Can you provide an example of how this works, and maybe a test case?

egonz avatar Aug 25 '20 15:08 egonz

Hi Eddie, could you expand on what you mean by "running gnostic doesn't include it?" The go_package option is in the OpenAPI proto files (e.g. openapiv2/OpenAPIv2.proto). Might you be referring to the output of the gnostic-grpc plugin?

timburks avatar Sep 09 '20 22:09 timburks

Hi Tim,

I'm referring to "option go_package" in the proto file. There is a PR to add this into gnostic which I linked to above. This would ideally produce something like:

option go_package = "com.foo;bar";

It's mentioned here:

https://developers.google.com/protocol-buffers/docs/reference/go-generated

egonz avatar Sep 16 '20 21:09 egonz

👍 from me

maurerbot avatar Jun 10 '21 20:06 maurerbot

I noticed https://github.com/google/gnostic-grpc/pull/65 add this into the grpc plugin in August, but there hasnt been any gnostic-* release since April/May. Is there any plan to cut a new release?

milosgajdos avatar Nov 21 '21 12:11 milosgajdos