globalfoundries-pdk-libs-gf180mcu_fd_pr icon indicating copy to clipboard operation
globalfoundries-pdk-libs-gf180mcu_fd_pr copied to clipboard

Updated exit code for DRC regression

Open mkkassem opened this issue 3 years ago • 6 comments
trafficstars

Fixes #<64>

mkkassem avatar Nov 24 '22 01:11 mkkassem

did an first overview of the python scripts as requested by @atorkmabrains (/cc @mithro)

proppy avatar Nov 25 '22 01:11 proppy

@atorkmabrains

mkkassem avatar Nov 25 '22 18:11 mkkassem

@atorkmabrains

mkkassem avatar Nov 27 '22 16:11 mkkassem

@mkkassem I did answer all the questions and I'll make the necessary updates.

atorkmabrains avatar Nov 28 '22 16:11 atorkmabrains

@atorkmabrains

@mkkassem I did answer all the questions

I still see some comments un-addressed, in https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/pull/78/files

and I'll make the necessary updates.

Please update this pull request w/ your changes, so that we can keep the review and the code changes in context.

proppy avatar Nov 29 '22 06:11 proppy

@atorkmabrains I'll be working on it today and tomorrow.

atorkmabrains avatar Nov 29 '22 06:11 atorkmabrains