globalfoundries-pdk-ip-gf180mcu_fd_ip_sram icon indicating copy to clipboard operation
globalfoundries-pdk-ip-gf180mcu_fd_ip_sram copied to clipboard

Incorrect Address width in descriptions for 3 SRAM modules

Open shaos opened this issue 2 years ago • 5 comments

Expected Behavior

gf180mcu_fd_ip_sram__sram256x8m8wm1 should have A[7:0] gf180mcu_fd_ip_sram__sram512x8m8wm1 should have A[8:0] gf180mcu_fd_ip_sram__sram64x8m8wm1 should have A[5:0]

Actual Behavior

in documentation all sram modules have A[6:0] as address description so it's correct only for sram128x8 (this is only documentation issue - in verilog everything looks ok)

Steps to Reproduce the Problem

Look into these 3 CSV files: cells/gf180mcu_fd_ip_sram__sram256x8m8wm1/specs/1_pins_desc.csv:A[6:0],Input,"Address Input. This Address input port is used to cells/gf180mcu_fd_ip_sram__sram512x8m8wm1/specs/1_pins_desc.csv:A[6:0],Input,"Address Input. This Address input port is used to cells/gf180mcu_fd_ip_sram__sram64x8m8wm1/specs/1_pins_desc.csv:A[6:0],Input,"Address Input. This Address input port is used to

Specifications

  • Version:
  • Platform:

shaos avatar Nov 28 '22 00:11 shaos

Initially noticed this problem here: https://gf180mcu-pdk.readthedocs.io/en/latest/IPs/ips.html

shaos avatar Nov 28 '22 00:11 shaos

@atorkmabrains - Could you take a look?

mithro avatar Nov 28 '22 16:11 mithro

@FaragElsayed2 Could you please review the documentation?

atorkmabrains avatar Apr 10 '23 00:04 atorkmabrains

@atorkmabrains I have checked it

FaragElsayed2 avatar Apr 10 '23 08:04 FaragElsayed2

Thanks @FaragElsayed2

atorkmabrains avatar Apr 10 '23 08:04 atorkmabrains