gin-config icon indicating copy to clipboard operation
gin-config copied to clipboard

Feature request: Read gin file from google cloud bucket path

Open OhadRubin opened this issue 3 years ago • 3 comments

Hey, I've seen libraries like T5X that are able to read model configs from cloud buckets. As a product from google I kind of expected this feature to be implemented here and was surprised to find it wasn't. Implementation plan:

  1. save gin file from remote path into a temporary file
  2. use that as the gin file

OhadRubin avatar Nov 10 '22 05:11 OhadRubin

Hi @OhadRubin, after some time searching for a solution, I found this code: https://github.com/google/gin-config/blob/1b6f0548f6dbf71ca97e1ab3ca97f955da5ec508/gin/tf/utils.py#L31

Using it I was able to read gin files from a GCS bucket. I think that frameworks like T5 and T5x are able to to it because they also import this code.

Best, Marcos

marcospiau avatar Jun 06 '23 03:06 marcospiau

I actually found this at some point too, this should really be added to the documentation!

OhadRubin avatar Jun 06 '23 06:06 OhadRubin

Yes, it really should!

marcospiau avatar Jun 07 '23 00:06 marcospiau