gin-config icon indicating copy to clipboard operation
gin-config copied to clipboard

TF2.0 compatibility?

Open evancasey opened this issue 5 years ago • 4 comments

Does this work with TF 2.0 / is compatibility on the roadmap? Great work so far on this.

evancasey avatar Mar 20 '19 15:03 evancasey

Also interested in the answer, as I have already started using TF 2.0.

foxik avatar Mar 20 '19 20:03 foxik

For anyone interested: I've got a minimally modified fork here. Haven't hit any issues yet, but not heavily tested.

jackd avatar May 02 '19 01:05 jackd

Thanks @jackd if you want to make a PR we can review it and test it.

sguada avatar May 02 '19 14:05 sguada

--> import gin.tf.external_configurables

../gin/tf/external_configurables.py in <module>
    144 # Distribution strategies.
--> 145 config.external_configurable(tf.contrib.distribute.MirroredStrategy,
    146                              module='tf.contrib.distribute')

AttributeError: module 'tensorflow' has no attribute 'contrib'

gin/tf/external_configurables.py contains tf.contrib.distribute.MirroredStrategy from tf.contrib.distribute package that is not in TF2.0.

Commenting out that line solves the problem.

soCzech avatar Sep 22 '19 09:09 soCzech