gf180mcu-pdk icon indicating copy to clipboard operation
gf180mcu-pdk copied to clipboard

Wrong commands in LEF file

Open thesourcerer8 opened this issue 2 years ago • 9 comments

Expected Behavior

The LEF files should be conforming to the fileformat specification

Actual Behavior

There are wrong commands in the LEF files: grafik

thesourcerer8 avatar Dec 04 '22 19:12 thesourcerer8

gf180mcu_fd_sc_mcu9t5v0__antennaDIFFAREA should be ANTENNADIFFAREA instead.

thesourcerer8 avatar Dec 04 '22 20:12 thesourcerer8

Somehow ANTENNA was replaced by with the antenna cell name, perhaps a TCL scope variable override issue?

thesourcerer8 avatar Dec 04 '22 20:12 thesourcerer8

Nice catch, we'll get a fix in.

QuantamHD avatar Dec 04 '22 20:12 QuantamHD

This is essentially a duplicate of #104, since the same string replacement caused both.

RTimothyEdwards avatar Dec 04 '22 21:12 RTimothyEdwards

I believe this is fixed by https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_sc_mcu9t5v0/pull/23

mithro avatar Dec 05 '22 00:12 mithro

https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_sc_mcu9t5v0/pull/23 was merged. Can this be closed?

umarcor avatar Dec 05 '22 14:12 umarcor

Can I get these changes into the gfmpw-0d Caravel branch, or will this go into a different branch (which one?), or is there another way to get this fix into a repo with gfmpw-0d ?

thesourcerer8 avatar Dec 28 '22 15:12 thesourcerer8

@jeffdi @RTimothyEdwards

QuantamHD avatar Dec 28 '22 18:12 QuantamHD

This fix has been in open_pdks since three weeks ago, and by extension should be in volare. It does not specifically "go into" the caravel repository, although the various commit numbers recorded for the library repositories should all be up-to-date.

RTimothyEdwards avatar Dec 29 '22 16:12 RTimothyEdwards