gematria icon indicating copy to clipboard operation
gematria copied to clipboard

Only add definitions for used registers

Open boomanaiden154 opened this issue 1 year ago • 5 comments

This patch makes the BHive to Exegesis conversion script only include definitions for registers needed by the snippet rather than a random set. This makes the outputs cleaner and will help keep things clean later on when setting a loop register (and also make information available to determine if/where there are conflicts).

boomanaiden154 avatar Feb 29 '24 09:02 boomanaiden154

should it have a test?

mtrofin avatar Feb 29 '24 22:02 mtrofin

Existing tests have been updated (which should be enough coverage here) now that testing infrastructure is in place.

boomanaiden154 avatar Mar 05 '24 06:03 boomanaiden154

I accidentally merged in #52 into this branch (tried to do stacked PRs and forgot how the DAG was setup while being overly zealous with the merge button). I can probably fix this if it's really necessary but the only changes from that PR (which was approved) are json.test, and lines 305-314.

boomanaiden154 avatar Mar 08 '24 08:03 boomanaiden154

This is now part of a PR stack, depending on #71.

boomanaiden154 avatar Mar 12 '24 05:03 boomanaiden154

This is now part of a PR stack, depending on #71.

SG, let's get #71 merged first.

ondrasej avatar Mar 14 '24 12:03 ondrasej

I'll wait with reviewing until #71 is merged and we have this based just on main.

ondrasej avatar Jun 26 '24 15:06 ondrasej

I'll wait with reviewing until https://github.com/google/gematria/pull/71 is merged and we have this based just on main.

I've merge main into the branch, so the diff should be clean now.

boomanaiden154 avatar Jun 26 '24 16:06 boomanaiden154