GroupNorm missing from NNX normalization layer

Open treigerm opened this issue 1 year ago • 2 comments

There's currently no implementation of group normalization in the NNX normalization layers. Is there a specific reason for why it is not implemented at the moment? If not I would be happy to open a PR and implement it.

Jul 17 '24 10:07 treigerm

Hey @treigerm, no particular reason other than we haven't gotten to it. Feel free to send a PR, happy to review it. Take a look at how the other layers have been ported and check the tests for these layers, we check numerical equivalence with Linen layers and tests combinations of parameters.

Jul 17 '24 13:07 cgarciae

Great, will look at the other layers and will send a PR by the end of this week.

Jul 17 '24 14:07 treigerm