flax icon indicating copy to clipboard operation
flax copied to clipboard

Fix broken links in docs/nnx/mnist_tutorial.md

Open bionicles opened this issue 1 year ago • 4 comments

pointed to prev location

What does this PR do?

fixes a couple of broken links to the notebook for the mnist tutorial

Fixes # (issue)

Checklist

  • [x] This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other checks if that's the case).
  • [ ] This change is discussed in a Github issue/ discussion (please add a link).
  • [x] The documentation and docstrings adhere to the documentation guidelines.
  • [ ] This change includes necessary high-coverage tests. (No quality testing = no merge!)

I personally checked the fixed links: https://colab.research.google.com/github/google/flax/blob/main/docs/nnx/mnist_tutorial.ipynb https://github.com/google/flax/blob/main/docs/nnx/mnist_tutorial.ipynb

both worked after adding /nnx/ between /docs/ and mnist_tutorial.ipynb

bionicles avatar Jul 08 '24 10:07 bionicles

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

like this? i didnt check the other nnx notebooks, they might need fixes also, checking ...

bionicles avatar Jul 09 '24 20:07 bionicles

didn't see any links in the other notebooks in the docs/nnx folder

bionicles avatar Jul 09 '24 20:07 bionicles

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (31adb00) to head (d4d9293). Report is 78 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #4060    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files        106     107     +1     
  Lines      13582   13824   +242     
======================================
- Misses     13582   13824   +242     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 09 '24 22:07 codecov-commenter