flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

Fixes for Dart imports

Open insertjokehere opened this issue 1 year ago • 8 comments

Fixes https://github.com/google/flatbuffers/issues/7609 Fixes https://github.com/google/flatbuffers/issues/8379

This PR builds on the work from https://github.com/google/flatbuffers/pull/8259 to:

  • Add a simple test to catch regressions in this area
  • Fix an issue where include chains (a includes b which includes c) are naively represented as a single import in Dart, which doesn't reflect how Dart handles imports. I've adjusted the Dart code generator to include an export statement to match import statements for files in the same namespace to ensure that include chains work in the generated code

insertjokehere avatar Aug 20 '24 02:08 insertjokehere

@CasperN @vaind Sorry to tag you out of the blue. This part of the modification is very important to me. Can you promote the merger of PR?

fawdlstty avatar Nov 15 '24 01:11 fawdlstty

I'm not a maintainer so I don't have merge permissions

vaind avatar Nov 15 '24 07:11 vaind

@aardappel Sorry to tag you out of the blue. Can you promote the merger of PR?

fawdlstty avatar Nov 18 '24 06:11 fawdlstty

This was merged: https://github.com/google/flatbuffers/pull/8313

Can you rebase this one, seems there may be some conflicts.

aardappel avatar Nov 18 '24 19:11 aardappel

There also seem to be dart codegen changes to the generated files that are not included in this PR

aardappel avatar Nov 18 '24 19:11 aardappel

@aardappel thanks for the review - I've rebased and updated the generated bindings. Happy to squash this down before merge.

insertjokehere avatar Nov 18 '24 20:11 insertjokehere

There also seem to be dart codegen changes to the generated files that are not included in this PR

This still seems to be an issue

aardappel avatar Nov 18 '24 23:11 aardappel

This pull request is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

github-actions[bot] avatar May 20 '25 20:05 github-actions[bot]

This pull request was automatically closed due to no activity for 6 months plus the 14 day notice period.

github-actions[bot] avatar Jun 03 '25 20:06 github-actions[bot]