flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard
verified publisher icon google

[.NET] Fix VerifyUnion using wrong offset for typeId

Open 0x4261756D opened this issue 1 year ago • 2 comments

The offset was overwritten to point to the data before the typeId was set.

0x4261756D avatar Jul 12 '24 01:07 0x4261756D

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 12 '24 01:07 google-cla[bot]

Oh well, too bad having a Google account is a requirement for contributing. Seems like this change won't make its way into the repo then I guess.

ghost avatar Jul 14 '24 03:07 ghost

Would it be possible to get it merged? It is causing some problems in my dotnet apps and this fixes it.

jmarchalgomez avatar Feb 12 '25 10:02 jmarchalgomez

Would it be possible to get it merged? It is causing some problems in my dotnet apps and this fixes it.

Since I do not intend to sign Google's CLA, I don't think there is a chance for this to land. If you don't have a problem with signing the CLA, feel free to open your own PR with these changes, maybe then they could be merged.

ghost avatar Feb 12 '25 15:02 ghost

@0x4261756D I fully understand. I do not even know if I am allowed to sign it. Can someone from the Google Team just include the fix? @dbaileychess

jmarchalgomez avatar Feb 12 '25 16:02 jmarchalgomez