flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

Bugfix: grpc python code generation location and file suffix

Open fliiiix opened this issue 1 year ago • 4 comments

Follow up from #8356.

This addresses the regression for the location where the grpc file is generated and changes the default suffix back to _fb again instead of .fb.

(See commit messages for more details).

fliiiix avatar Jul 11 '24 14:07 fliiiix

Can this be merged @dbaileychess or does it need something else?

fliiiix avatar Aug 09 '24 13:08 fliiiix

Any update if this can be merged? @dbaileychess @anton-bobukh

fliiiix avatar Nov 13 '24 16:11 fliiiix

Rebased to master any chance this can be merged @dbaileychess @anton-bobukh as this still breaks imports in python

fliiiix avatar Feb 14 '25 08:02 fliiiix

rebased again

fliiiix avatar Mar 20 '25 08:03 fliiiix

@aardappel or @dbaileychess any chance this can also be merged to fix the regression after this was merged now https://github.com/google/flatbuffers/pull/8500

fliiiix avatar Jun 24 '25 10:06 fliiiix

CI issues seem unrelated

aardappel avatar Jun 25 '25 05:06 aardappel

Thanks :)

aardappel avatar Jun 25 '25 05:06 aardappel

Thank you :sparkles: good to see that flatbuffers is still maintained

fliiiix avatar Jun 25 '25 06:06 fliiiix