flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

[Python] fixed path being ignored in GeneratePythonGRPC

Open tasansal opened this issue 2 years ago • 4 comments

Hi,

The Python gRPC code generator was ignoring -o <output_dir> option in flatc. With this, it generates all the services within the <output_dir> and under the correct namespace(s), i.e., Python sub-modules.

I had to remove the custom logic and use BaseGenerator's file prefix logic, which seems to work as expected.

I believe this closes #7397.

Thanks.

tasansal avatar Aug 20 '23 17:08 tasansal

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 20 '23 17:08 google-cla[bot]

@dbaileychess I think this should also be included in the next release. It fixes a bug I introduced in #6456

mustiikhalil avatar Nov 23 '23 11:11 mustiikhalil

Rebased to main so it's up to date

tasansal avatar Nov 23 '23 12:11 tasansal

@dbaileychess friendly ping, would be great to get this merged

jarkenau avatar Feb 20 '24 07:02 jarkenau