flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

fix bug: bool Array values are always false

Open rampage-raw opened this issue 2 years ago • 5 comments

Using [] in lua doesn't access the characters of a string, which results in the value of an array of type bool always being false

rampage-raw avatar Aug 16 '23 06:08 rampage-raw

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 16 '23 06:08 google-cla[bot]

Can you add a test case to tests/luatest.lua for this change?

le-michael avatar Sep 21 '23 01:09 le-michael

Can you add a test case to tests/luatest.lua for this change?

There are still some bugs in this fix, I'll take care of them later and add test cases.

rampage-raw avatar Oct 11 '23 11:10 rampage-raw

@Cindlory would you like me to pick up this PR & add a test?

There's also an issue with how bools are encoded in general, addressed in #8252

serprex avatar Mar 11 '24 14:03 serprex

@Cindlory would you like me to pick up this PR & add a test?

There's also an issue with how bools are encoded in general, addressed in #8252

@serprex no problem. Due to project changes at work, I put this issue on hold. My PR may not fix the problem, I remember it may be related to Lua's generated code.

rampage-raw avatar Mar 11 '24 15:03 rampage-raw