flatbuffers
flatbuffers copied to clipboard
Add Pre-commit checks
it will be great to have presubmits running that will do the job for us. It will help reduce the hassle for manually checking what are the things that were left or what script has not run or what checks are not run. This will include the presubmits for:
- Test cases
- Code generation
- Checking if the generated code is good
We do have these
https://github.com/google/flatbuffers/blob/master/.github/workflows/build.yml
These are after submitting checks, not presubmit. I mean https://pre-commit.com/
Gotcha, I'll reopen this as "precommit" as per your link
This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale
, or this will be closed in 14 days.
Hello, I am currently working this enhancement, need time to learn git and per-commit. Thank-you
@rishabhdeepsingh This should PR should do it ! https://github.com/google/flatbuffers/pull/8193