flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

Add Pre-commit checks

Open rishabhdeepsingh opened this issue 1 year ago • 6 comments

it will be great to have presubmits running that will do the job for us. It will help reduce the hassle for manually checking what are the things that were left or what script has not run or what checks are not run. This will include the presubmits for:

  • Test cases
  • Code generation
  • Checking if the generated code is good

rishabhdeepsingh avatar Oct 30 '22 17:10 rishabhdeepsingh

We do have these

https://github.com/google/flatbuffers/blob/master/.github/workflows/build.yml

CasperN avatar Oct 31 '22 17:10 CasperN

These are after submitting checks, not presubmit. I mean https://pre-commit.com/

rishabhdeepsingh avatar Oct 31 '22 18:10 rishabhdeepsingh

Gotcha, I'll reopen this as "precommit" as per your link

CasperN avatar Nov 03 '22 16:11 CasperN

This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

github-actions[bot] avatar May 04 '23 20:05 github-actions[bot]

Hello, I am currently working this enhancement, need time to learn git and per-commit. Thank-you

KarthikeyaThotak avatar May 05 '23 11:05 KarthikeyaThotak

@rishabhdeepsingh This should PR should do it ! https://github.com/google/flatbuffers/pull/8193

Bazifrasool avatar Sep 08 '23 21:09 Bazifrasool