flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

[TS/Rust/Go/Dart] Fix handling of +/-inf defaults in codegen

Open jkuszmaul opened this issue 2 years ago • 7 comments

+/-inf were not being handled, and so invalid typescript was being generated when a float/double had an infinite default value. NaN was being handled correctly.

jkuszmaul avatar Oct 17 '22 15:10 jkuszmaul

And I see Rust, Go, and Dart also don't handle this correctly.....

jkuszmaul avatar Oct 17 '22 16:10 jkuszmaul

Okay, everything is passing except for the Go test, and I must be blind because I cannot figure out what the Go test is failing on from looking at the output.

jkuszmaul avatar Oct 17 '22 17:10 jkuszmaul

Okay, everything is passing except for the Go test, and I must be blind because I cannot figure out what the Go test is failing on from looking at the output.

They seem to be the same up to addresses (I copied the output, changed spaces to newlines, and used diff to compare)

CasperN avatar Oct 17 '22 18:10 CasperN

The Kotlin MacOS build looks just flaky, not sure how to rerun it (other than just making a dummy commit or rebasing on mater again or some similarly silly thing).

jkuszmaul avatar Oct 26 '22 17:10 jkuszmaul

@CasperN @dbaileychess The Kotlin Linux build seems to have flaked out this time; not quite sure what the appropriate response from me is when builds fail in this manner, or if I've just gotten particularly unlucky with flakiness to have two different Kotlin tests flake out in a row.

jkuszmaul avatar Oct 27 '22 20:10 jkuszmaul

I updated that runner https://github.com/google/flatbuffers/commit/e54536127ccb66360146d1d0fc486f126d3f4c41 due to this thread: https://github.com/gradle/wrapper-validation-action/issues/40

dbaileychess avatar Oct 27 '22 20:10 dbaileychess

Sorry, i mistyped the fix, rerunning the CI.

dbaileychess avatar Oct 27 '22 23:10 dbaileychess