flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

idl_parser does not retrieve attribute `deprecated` from binary schema bfbs files[ c++, all]

Open jsyqrt opened this issue 2 years ago • 1 comments

I wrote a schema file like this:

table Root {
  mystring: string;
  myint: int(deprecated);
}

root_type Root;

and compiled it with flatc.exe with flags: --binary --schema, got a bfbs file.

When writing my own idl parser based on flatbuffers::Parser, i found that the value of deprecated of flatbuffers::FieldDef is not correctly initialized.

After debugging a little bit, I reached a function named FieldDef::Deserialize in src/idl_parser.cpp, it seems that the function does not set the deprecated field as expected.

Am i correct? thanks for your help.

jsyqrt avatar Oct 08 '22 07:10 jsyqrt

add two lines, it works for me

jsyqrt avatar Oct 08 '22 07:10 jsyqrt

This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

github-actions[bot] avatar Apr 08 '23 20:04 github-actions[bot]

This issue was automatically closed due to no activity for 6 months plus the 14 day notice period.

github-actions[bot] avatar Apr 23 '23 20:04 github-actions[bot]