flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

[TS/JS] New flatbuffers bundle not exactly equivalent to old single file

Open bjornharrtell opened this issue 3 years ago • 1 comments
trafficstars

A way to create a single file flatbuffers.js was done in https://github.com/google/flatbuffers/pull/7449.

I however noted when doing https://github.com/google/flatbuffers/pull/7510#issuecomment-1238521420 that it's not exactly equivalent. The old https://unpkg.com/[email protected]/js/flatbuffers.js exports a symbol named flatbuffers where as the new one exports the content of flatbuffers.

bjornharrtell avatar Sep 07 '22 05:09 bjornharrtell

Not sure about this now. I realize the old file actually both export flatbuffers symbol and at the same time defines it as a global. That's kind of a "bastard" module.

But, a possible solution in https://github.com/google/flatbuffers/pull/7513.

bjornharrtell avatar Sep 07 '22 05:09 bjornharrtell

Not interested anymore.

bjornharrtell avatar Mar 04 '23 21:03 bjornharrtell