flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

Lack of parity with tensorflow/third_party/flatbuffers/build_defs.bzl

Open yeswalrus opened this issue 2 years ago • 3 comments

Support for bazel is really sadly lacking. There's no python support included, and the srcs attribute of flatbuffers_build_public is broken when srcs contains labels referencing file groups. The version, which appears to be a google internal fork, in tensorflow/third_party/flatbuffers/build_defs.bzl is significantly more advanced and resolves these problems. Is there any plan to upstream these?

Longer term, ideally there would be somelthing equivalent to https://rules-proto-grpc.com/en/latest/ but for flatbuffers

yeswalrus avatar Jun 23 '22 18:06 yeswalrus

No plans that I'm aware of

CasperN avatar Jun 28 '22 15:06 CasperN

I would love to help

squirrelnest1986 avatar Jun 29 '22 01:06 squirrelnest1986

@yeswalrus Yes, our bazel support isn't the greatest, mostly because we are a cmake-first project.

The tensorflow libraries are indeed better and we would be supportive to updating ours. That team is fully staffed and has the resources to make things better, compared to flatbuffers which is just volunteer work.

dbaileychess avatar Sep 27 '22 20:09 dbaileychess

This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

github-actions[bot] avatar Mar 29 '23 20:03 github-actions[bot]

This issue was automatically closed due to no activity for 6 months plus the 14 day notice period.

github-actions[bot] avatar Apr 13 '23 20:04 github-actions[bot]