flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

[golang] Add support for text parsing with json struct tags

Open aburdulescu opened this issue 3 years ago • 1 comments

Add struct tags to Go native structs generated when object API is used.

This allows to use the same JSON file as for C++ text parsing(i.e. snake_case vs CamelCase) and thus enabling text parsing for Go(when using object API).

See also issue #7004

aburdulescu avatar Jun 16 '22 16:06 aburdulescu

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 16 '22 16:06 google-cla[bot]

@CasperN Do you know Go?

dbaileychess avatar Aug 06 '22 05:08 dbaileychess

This LGTM, though I don't know Golang. Since it is a fairly simple change, if it does break people we can revert it easily enough. Thanks!

dbaileychess avatar Aug 08 '22 18:08 dbaileychess