flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

[TS/Bazel] Minor improvements to typescript.bzl

Open jkuszmaul opened this issue 2 years ago • 4 comments

  • Uses @...// dependencies so that flatbuffers can actually be used as an external repo (had forgotten to upstream this earlier).
  • Allows using flatbuffer_ts_library to generate reflection schemas in the same way that flatbuffer_cc_library does (but default it to off to avoid behavioral changes).
  • Pass through a package_name attribute to flatbuffer_ts_library to allow non-relative imports of generated typescript code.
  • Fix bazel build regression caused by #7342, re-implementing #7342.

jkuszmaul avatar May 10 '22 23:05 jkuszmaul

@dbaileychess not sure who to ask for review on this (also the android build is looking flaky?).

cc @AustinSchuh as the last known maintainer for flatbuffers bazel rules...

jkuszmaul avatar Jun 07 '22 23:06 jkuszmaul

@AustinSchuh Could you take a look?

dbaileychess avatar Jun 14 '22 22:06 dbaileychess

Thank you for the fix!

liuliu avatar Jun 15 '22 01:06 liuliu

@dbaileychess ping

jkuszmaul avatar Jun 22 '22 17:06 jkuszmaul