flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

Publish a 2.0.5 release?

Open fjarri opened this issue 3 years ago • 8 comments

Somewhere between Flatbuffers 2.0.0 and 2.0.5 (current) there has been a backwards incompatible change in how generated Rust files are laid out (#6731, if I'm not mistaken). The current published release is 2.0.0, so it creates conflicts when, say, it is used on CI, while developer machines may have a newer version (e.g. homebrew has only 2.0.5 available). Would it be possible to update the release?

fjarri avatar Feb 04 '22 22:02 fjarri

@CasperN Does rust need a version increase and release?

dbaileychess avatar Feb 04 '22 23:02 dbaileychess

A published 2.0.5 on npm would be nice as well. The current published version 2.0.4 is incompatible since the BigInt change (ace4a37f228ec64a0e9d07c0d2676b4431d823de)

tsturm avatar Feb 06 '22 14:02 tsturm

Does rust need a version increase and release?

The change in how files are laid out is in flatc so the next flatc release should have been 3.0, not 2.0.5

However I think we could make the new file layout behavior opt-in rather than by default and call it a patch

CasperN avatar Feb 06 '22 16:02 CasperN

Hmm, this is where versioning would get really messy. I feel like jumping to 3.0 signals to everyone that their are major changes, yet it just a small change to one language.

dbaileychess avatar Feb 08 '22 21:02 dbaileychess

I feel like jumping to 3.0 signals to everyone that their are major changes, yet it just a small change to one language.

Agreed, I can change the default to be non-breaking. I didn't expect that we'd release again so soon, or that we'd have any non-major releases, so I'm happy if this means we're releasing more

CasperN avatar Feb 09 '22 17:02 CasperN

We are at v2.0.6 now. @CasperN do you want to do the pushing of the rust cargo package?

dbaileychess avatar Feb 22 '22 04:02 dbaileychess

Done - I just published it, but note that the fix for this issue didn't have to do with the cargo package, and also the cargo package is now at 2.1.0 because we added no-std support.

CasperN avatar Feb 22 '22 16:02 CasperN

Any updates on this? It would be nice to have a release with #7273.

fjarri avatar May 16 '22 21:05 fjarri